On Wed, 11 Oct 2017 16:49:10 +0200, Johan Hovold wrote:
On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote:
On Wed, 11 Oct 2017 16:20:31 +0200, Johan Hovold wrote:
Unrelated to this patch, but this driver fails to kill the ep1_in_urb (which is submitted in this function) in case of later probe errors. This can lead to use-after-free or crashes in the completion callback.
Yes, a good catch. Below is the fix patch.
-- 8< -- From: Takashi Iwai tiwai@suse.de Subject: [PATCH] ALSA: caiaq: Fix stray URB at probe error path
caiaq driver doesn't kill the URB properly at its error path during the probe, which may lead to a use-after-free error later. This patch addresses it.
Reported-by: Johan Hovold johan@kernel.org Signed-off-by: Takashi Iwai tiwai@suse.de
Looks good to me:
Reviewed-by: Johan Hovold johan@kernel.org
Thanks. It's rather a material for for-linus with Cc to stable, so marked it and queued.
Takashi