14 Oct
2011
14 Oct
'11
9:20 p.m.
On Fri, Oct 14, 2011 at 04:31:38PM +0530, Ashish Chavan wrote:
- /* ADCs */
- SND_SOC_DAPM_ADC("ADC Left", "Capture", DA7210_STARTUP3, 5, 1),
- SND_SOC_DAPM_ADC("ADC Right", "Capture", DA7210_STARTUP3, 6, 1),
- /* Output Side */
- /* DACs */
- SND_SOC_DAPM_DAC("DAC Left", "Playback", DA7210_STARTUP2, 5, 1),
- SND_SOC_DAPM_DAC("DAC Right", "Playback", DA7210_STARTUP2, 6, 1),
These are also being enabled in the probe() function using completely different registers - there the registers used are _ADC and _DAC. What's going on there? It's good to see the stuff in the startup() function gone but almost all of the probe() just shouldn't be there in a properly written driver and much of it looks like stuff that DAPM should be taking care of.