Re: [REGRESSION] ALSA: firewire-lib: heavy digital distortion with Fireface 800

On Thu, 25 Jul 2024 00:24:29 +0200, edmund.raile wrote:

Bisection revealed that the bitcrushing distortion with RME FireFace 800 was caused by 1d717123bb1a7555 ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning").

Reverting this commit yields restoration of clear audio output. I will send in a patch reverting this commit for now, soonTM.

#regzbot introduced: 1d717123bb1a7555

While it's OK to have a quick revert, it'd be worth to investigate further what broke there; the change is rather trivial, so it might be something in the macro expansion or a use of flex array stuff.

thanks,

Takashi