Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

On 10/14/2014 04:58 PM, Shuah Khan wrote: [...]

switch (cmd) { case SNDRV_PCM_TRIGGER_START:

• err = media_get_audio_tkn(&subs->dev->dev);
  

• if (err == -EBUSY) {
  

• 	dev_info(&subs->dev->dev, "%s device is busy\n",
  

• 			__func__);
  

In my opinion this should not dev_info() as this is out of band error signaling and also as the potential to spam the log. The userspace application is already properly notified by the return code.

• 	return err;
  

• }
  

  err = start_endpoints(subs, false); if (err < 0) return err;