13 Mar
2020
13 Mar
'20
3:45 p.m.
On Thu, Mar 12, 2020 at 03:44:23PM +0100, Guennadi Liakhovetski wrote:
In the VirtIO case the sof_pcm_open() function isn't called on the host during guest streaming, which then leaves "work" structures uninitialised. However it is then used to handle position update messages from the DSP. Move their initialisation to immediately after allocation of the containing structure.
This is good practice in general, independently of anything you're doing with VirtIO - it makes it harder to introduce bugs. I'd split this out and send it separately.