On Mon, Oct 14, 2019 at 9:46 AM Shuming [范書銘] shumingf@realtek.com wrote:
On Tue, Oct 08, 2019 at 09:33:24AM +0000, Shuming [范書銘] wrote:
In chromebook case, the machine driver will get the r0 calibration data and temperature from VPD. Therefore, the codec exports r0 and temperature config API for it.
This doesn't seem to apply against current code, please check and resend.
Thanks Mark. I will check with Google whether still using this method. If so, I will resend the patch.
Hi Mark and Shuming, Thank you for the suggestion. I agree that it is better to use device property to pass r0 and temperature through device property. I am working on coreboot changes to parse data from VPD, and set device property "rt1011,temperature_calib" and "realtek,r0_calib". I think the patch in rt1011 driver will be much simpler once we have that device property ready. And there will be no machine driver change needed.
Thanks!
------Please consider the environment before printing this e-mail.