On 04/07/2022 18:50, Stephan Gerhold wrote:
On Mon, Jul 04, 2022 at 05:38:24PM +0200, Krzysztof Kozlowski wrote:
Convert the Samsung SDM845 sound card bindings to DT schema.
Nitpick: s/Samsung/Qualcomm
Yes, thanks.
Changes during conversion: do not require 'codec' under dai-links - not present in all nodes of examples and DTS; not required by the driver.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
.../devicetree/bindings/sound/qcom,sdm845.txt | 91 ---------- .../bindings/sound/qcom,sdm845.yaml | 166 ++++++++++++++++++ 2 files changed, 166 insertions(+), 91 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.yaml
Can you check if you can just add the compatibles to the existing qcom,sm8250.yaml? It should be more or less identical given that the DT parsing code in the driver is shared between all these SoCs. I already added the MSM8916 compatibles there a while ago.
It also documents some additional properties ("pin-switches", "widgets") that are supported for SDM845 through the common code but are missing in its binding documentation.
I thought about merging these but then I would have to disallow these properties, as I assumed these are not valid for SDM845. Are you saying that pin-switches and widgets are actually valid for SDM845?
Best regards, Krzysztof