Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for StarFive JH8100 SoC

On 2023/12/22 0:07, Krzysztof Kozlowski wrote:

On 21/12/2023 04:32, Xingyu Wu wrote:

...

• dma-names:
• items:

•  - const: tx
  

•  - const: rx
  

• minItems: 1
• cdns,i2s-max-channels:

Custom properties after generic, so after sound-dai-cells. The coding style now mentions this.

Noted.

...

• description: |

•  Number of I2S max stereo channels supported by the hardware.
  

• $ref: /schemas/types.yaml#/definitions/uint32
• minimum: 1
• maximum: 8
• "#sound-dai-cells":
• const: 0

+required:

• • compatible
• • reg
• • clocks
• • clock-names
• • resets

+oneOf:

• • required:

•  - dmas
  

•  - dma-names
  

• • required:

•  - interrupts
  

+unevaluatedProperties: false

This is not correct without allOf: which should point you to missing $ref to dai-common.

Will fix.

Best regards, Krzysztof

Thanks, Xingyu Wu