On 14/04/2022 02:44, Yang Li wrote:
The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.
Eliminate the follow coccicheck warning: ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
Applied thanks,
--srini
drivers/slimbus/qcom-ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index ec58091fc948..c0c4f895d76e 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev) }
ctrl->irq = platform_get_irq(pdev, 0);
- if (ctrl->irq < 0) {
dev_err(&pdev->dev, "no slimbus IRQ\n");
- if (ctrl->irq < 0) return ctrl->irq;
}
sctrl = &ctrl->ctrl; sctrl->dev = &pdev->dev;