28 Feb
2013
28 Feb
'13
12:02 p.m.
On Thursday, February 28, 2013 10:32:15 Mike Looijmans wrote:
That's a big improvement over "rx_num_evt". The first time I saw this struct, I thought I had to set rx_num_evt to the number of receiving AXR pins in use.
Maybe call it "rx_min_fifo_depth" because just "depth" might be interpreted as the capaciity or maximum size of the fifo, while in fact the parameter is a minimum amount of data to be put into the FIFO buffer. Of maybe "rx_fifo_thd" to indicate it's a threshhold. And use the same name for the "tx" part as well (tx_fifo_thd or tx_fifo_min_depth).
"rx_min_fifo_depth" or "tx_min_fifo_depth" seem to be fine. If I'll have time, I'll prepare patch. That's cosmetic upgrade, but should help others.
Michal.