* Steve Sakoman sakoman@gmail.com [080908 11:16]:
On Mon, Sep 8, 2008 at 2:56 AM, Mark Brown broonie@sirena.org.uk wrote:
On Sat, Sep 06, 2008 at 11:41:42PM -0700, sakoman@gmail.com wrote:
+config SND_SOC_TWL4030
tristate
depends on SND_SOC && I2C
Sorry, didn't notice earlier: this should depend on whatever the config option is for the TWL4030 core driver rather than on I2C since it doesn't actually interact with I2C directly. Although in most applications this won't make much odds since the machine driver will select the codec driver and select ignores the dependencies anyway.
You are correct. Good catch, though as you say it doesn't really matter in practice.
I will re-submit a version with this fixed nonetheless.
Pushing this series to linux-omap today with the re-submitted version of patch 3/5.
Tony