8 Nov
2016
8 Nov
'16
2:20 a.m.
Hi Russell
This is wrong. If platform is NULL, PTR_ERR() will return zero, which will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(), it leads to exactly this kind of cockup - and it's unnecessary here because platform_device_register_full() does not return NULL.
Thank you for your feedback. Before sending v4 patch, I would like to confirm. Do you meand this ? # use IS_ERR() instead of IS_ERR_OR_NULL()
platform = platform_device_register_full(&pdevinfo); if (IS_ERR(platform)) return PTR_ERR(platform);
Yes, that's exactly correct.
Thanks ! I will send v4 patch
Best regards --- Kuninori Morimoto