On 19/01/2023 13:27, Srinivasa Rao Mandadapu wrote:
Update VA, RX and TX macro and lpass_tlmm clock properties and enable them.
Everything is an update and this does not explain what exactly you are updating in the nodes and why.
Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
.../qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 59 ++++++++++++++++++++++ 1 file changed, 59 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi index 81e0f3a..674b01a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi @@ -8,8 +8,67 @@
#include <dt-bindings/sound/qcom,q6afe.h>
+/delete-node/ &lpass_rx_macro;
Why?
+/delete-node/ &lpass_tx_macro; +/delete-node/ &lpass_va_macro;
/{ /* BOARD-SPECIFIC TOP LEVEL NODES */
- lpass_rx_macro: codec@3200000 {
compatible = "qcom,sc7280-lpass-rx-macro";
reg = <0 0x03200000 0 0x1000>;
Why? They are the same.
pinctrl-names = "default";
pinctrl-0 = <&lpass_rx_swr_clk>, <&lpass_rx_swr_data>;
Still the same...
clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&lpass_va_macro>;
clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
This is different...
#clock-cells = <0>;
#sound-dai-cells = <1>;
But this not.
Best regards, Krzysztof