Re: [alsa-devel] [PATCH] Add support for gain in softvol plugin

At Thu, 17 May 2007 15:00:35 -0700, Steve Longerbeam wrote:

Steve Longerbeam wrote:

Takashi Iwai wrote:

    At Thu, 10 May 2007 12:57:10 -0700,
    Steve Longerbeam wrote:

        Hi Takashi,

        Thanks, that's much better. I tried doing that myself a while ago, but I 
        must have been doing something wrong because the capture device wasn't 
        being recognized. But your version works.

        Version 4 of the patch is attached. It's much better, only two modified 
        files: pcm_softvol.c and HDA-Intel.conf.

        I also reduced the gain range, it's now -30 to +30 dB.

    I'm afraid that this choice would be bad for the current TLV
    representation.  The default resolution is 256, so -30/30 dB range
    doesn't match to this resolution.  We should change either resolution
    (e.g. 120, corresponding to 0.5dB step), or the range.

ok, that's no problem. How about we change the range to (in HDA-Intel.conf):

min_dB: -21.0
max_dB: 30.0

Hi Takashi, should I send another patch with this change?

Well, -21/30 isn't better than -30/30 since it doesn't match with the default resolutions (= 256). So, I think -30/30 choice is good, but it just needs the adjustment of resolution.

I committed your last patch with this fix now to ALSA HG tree.

Thanks!

Takashi