On 09/08/24 01:02, Mark Brown wrote:
On Wed, Aug 07, 2024 at 10:43:14AM +0530, Vijendar Mukunda wrote:
Fix the incorrect register offsets for acp error reason registers. Add 'acp_sw0_i2s_err_reason' as register field in acp descriptor structure and update the value based on the acp variant. ACP_SW1_ERROR_REASON register was added from Rembrandt platform onwards. Add conditional check for the same.
Fixes: 96eb81851012 ("ASoC: SOF: amd: add interrupt handling for SoundWire manager devices")
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_irq_handler’: /build/stage/linux/sound/soc/sof/amd/acp.c:407:26: error: ‘struct acp_dev_data’ h as no member named ‘pci_rev’ 407 | if (adata->pci_rev >= ACP_RMB_PCI_ID) | ^~
This patch is part of https://github.com/thesofproject/linux/pull/5103 which got successfully merged into sof github without any build errors. This patch is dependent on Link: https://patch.msgid.link/20240801111821.18076-10-Vijendar.Mukunda@amd.com which got already merged in to ASoC tree for-next base. It shouldn't cause build error if the dependent patch already merged.
/build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_power_on’: /build/stage/linux/sound/soc/sof/amd/acp.c:444:22: error: ‘struct acp_dev_data’ h as no member named ‘pci_rev’ 444 | switch (adata->pci_rev) { | ^~