Hi,
On 2/12/21 9:31 PM, Hans de Goede wrote:
On 2/11/21 12:13 PM, Jaroslav Kysela wrote:
<snip>
The sound driver implementation is really easy:
- call snd_ctl_led_request() when control LED layer should be automatically activated / it calls module_request("snd-ctl-led") on demand /
- mark all related kcontrols with SNDRV_CTL_ELEM_ACCESS_SPK_LED or SNDRV_CTL_ELEM_ACCESS_MIC_LED
So I've been running some tests with this,combined with writing UCM profiles for hw volume control, for some Intel Bay- and CherryTrail devices using Intel's Low Power Engine (LPE) for audio, which uses the ASoC framework.
My work / experiments for this are progressing a bit slower then I would like, but that is not the fault of this patch-set, but rather an issue with hw-volume control mapping, see below for details.
Leaving the ASoC implementation details aside, this patch-set works quite nicely to get the speaker mute-LED to work.
I've spend some more time this weekend playing with this and I've also added mic MUTE LED support for the ASoC rt5672 codec driver now using this.
I will post a RFC patch series with the ASoC rt5672 codec driver LED support soon, as adding an extra use-case for this will hopefully help with reviewing this.
FWIW there were some challenges, but those were not related to the driver API this patch set adds. The driver API works well for ASoC codec drivers.
Regards,
Hans
p.s.
One open issue is the lockdep issue which I reported in my previous email.