Re: [alsa-devel] [PATCH 4/4] pxa-ssp: switch from network mode to psp

On Wed, Mar 04, 2009 at 09:17:00PM +0100, Daniel Mack wrote:

• switch (priv->dai_fmt & SND_SOC_DAIFMT_FRAME_FORMAT_MASK) {
  

• case SND_SOC_DAIFMT_FF_I2S_32:
  

• 	/* These values are all found out by trying and
  

• 	 * failing a lot. PXA's SSP is all black magic and
  

• 	 * does not work like described in any datasheet.
  

• 	 */
  

• 	sspsp |= SSPSP_SFRMWDTH(32);
  

• 	sspsp |= SSPSP_SFRMDLY(32 * 2);
  

• 	sspsp |= SSPSP_EDMYSTOP(3);
  

• 	sspsp |= SSPSP_DMYSTOP(3);
  

• 	sspsp |= SSPSP_DMYSTRT(1);
  

• 	break;
  

*sigh*

I just saw that one of these bit fields we write to here is only available on PXA3xx - so we probably need the whole logic to be different for PXA2xx which makes everthing a lot more complicated.

Anyway, could the patch below be taken?

Thanks, Daniel