On Fri, Sep 02, 2016 at 02:44:40PM +0800, Mengdong Lin wrote:
On 08/24/2016 01:41 AM, Mark Brown wrote:
This seems *incredibly* implementation specific. Why wouldn't the driver for the thing implementing the topology be able to figure out the ordering here? What's the use case? What happens when we change away from DPCM?
There is another patch (04/13) to add generic flags and flag mask to PCM objects. So we'll allow users to set DPCM trigger ordering as flags as below, to avoid using trigger[] in ABI. The topology kernel driver will check the flag bits and set the proper trigger ordering to FE DAI links. If we change away from DPCM in the future, user can stop using these flags. And the 32-bit flags seems enough for future extension.
This doesn't seem much better to be honest, it's just shuffling the problem around. Why do these things need to be triggered in this particular order and why is that invisible to the system?