21 Jan
2020
21 Jan
'20
6:26 p.m.
On Tue, Jan 21, 2020 at 05:12:42PM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote:
Please fix your mailer to quote replies normally, it's hard to read your mails.
In what way is it part of the fix? This at least needs some sort of explanation somewhere, the changelog at least if not the code.
When we play subsequently we hear last played sound for moment.kfree clears the structure.
If the rtd is still being referenced after the kfree() you have a use after free bug so there's a serious problem there and this change is introducing a bug, you can only free things if they are not in use. At a bare minimum I need the changelog to clearly explain what the cause of the clicks is and how the change fixes that.