On Mon, Feb 10, 2014 at 04:24:43PM +0800, Xiubo Li-B47053 wrote:
Sorry, my misunderstanding about your comment.
Please ignore the last mail.
I will send v2 of this patch.
No, you don't need to.
Just rechecked it with RM. Your patch is correct.
I forgot I used A's WIDTH intentionally at the first place.
TSMA-> [15:0] TSMB-> [31:16] -> higher 16bits.
Thus its shift should be corresponding to A's WIDTH.
The patch is fine. Acked.
Thank you.
diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h index 9c9f957..75e1403 100644 --- a/sound/soc/fsl/fsl_esai.h +++ b/sound/soc/fsl/fsl_esai.h @@ -322,7 +322,7 @@ #define ESAI_xSMB_xS_SHIFT 0 #define ESAI_xSMB_xS_WIDTH 16 #define ESAI_xSMB_xS_MASK (((1 << ESAI_xSMB_xS_WIDTH) - 1) <<
ESAI_xSMB_xS_SHIFT)
-#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) &
ESAI_xSMA_xS_MASK)
+#define ESAI_xSMB_xS(v) (((v) >> ESAI_xSMA_xS_WIDTH) &
ESAI_xSMB_xS_MASK)
It should use ESAI_xSMB_xS_WIDTH.
Well, the ESAI_xSMB_xS_WIDTH is 0x0010(16), and ESAI_xSMB_xS_MASK will be 0xFFFF.
Thanks,
-- Best Regards, Xiubo