Re: [alsa-devel] [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

W dniu 28.06.2015 16:01, Timur Tabi pisze:

Maciej S. Szmigiero wrote:

...

  /* Are the RX and the TX clocks locked? */
  if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) {

•    ssi_private->cpu_dai_drv.symmetric_rates = 1;
  

•    if (!fsl_ssi_is_ac97(ssi_private))
  

•        ssi_private->cpu_dai_drv.symmetric_rates = 1;
  

Is this necessary? Why not just add fsl,ssi-asynchronous to the AC97 device tree node?

Because in the AC'97 mode the driver supports only one channel config and one sample format anyway the remaining settings controlled by this property don't do anything.

Since it should be safe to enable asymmetric rates with any AC'97 CODEC I think it is good to do it in driver than to add "fsl,ssi-asynchronous" to every AC'97 DT node.

Also the description of this property in fsl,ssi.txt looks like that it only makes sense in non-AC'97 mode.

Best regards, Maciej Szmigiero