26 Jul
2011
26 Jul
'11
9:16 a.m.
it uses an inline function snd_mask_min, which is declared in sound/pcm_params.h, but this file is not included by sound/pcm.h, where it is defined. including it manually, causes a huge number of errors. it would be very helpful, if pcm.h would be self-contained.
Well, pcm_params.h is just an additional header that aren't used by most drivers, so it doesn't make much sense to include such unconditionally from the common pcm.h.
then wouldn't it make sense to move those parts from pcm.h that depend on pcm_params.h to that header? especially the params_* family? at the moment pcm.h is not self-contained, which is not really what i expect from a header ...
tim