[alsa-devel] [ASoC]Changing the order of trigger in soc_pcm_trigger

6 Jun 2007


      Liam,
I have one suggestion.
Can we use this
if (rtd->codec_dai->ops.trigger) {
    	ret = rtd->codec_dai->ops.trigger(substream, cmd);
    	if (ret < 0)
    		return ret;
    }
if (rtd->cpu_dai->ops.trigger) {
    ret = rtd->cpu_dai->ops.trigger(substream, cmd);
    if (ret < 0)
    	return ret;
}
if (platform->pcm_ops->trigger) {
    ret = platform->pcm_ops->trigger(substream, cmd);
    if (ret < 0)
    	return ret;
}
Instead of
if (rtd->codec_dai->ops.trigger) {
    	ret = rtd->codec_dai->ops.trigger(substream, cmd);
    	if (ret < 0)
    		return ret;
    }
if (platform->pcm_ops->trigger) {
    ret = platform->pcm_ops->trigger(substream, cmd);
    if (ret < 0)
    	return ret;
}
if (rtd->cpu_dai->ops.trigger) {
    ret = rtd->cpu_dai->ops.trigger(substream, cmd);
    if (ret < 0)
    	return ret;
}
That means trigger the Cpu before pcm. Because most of the controllers
needs to be initialized and triggered before external DMA is
triggered.
Correct me if i am going wrong.
This was causing so many problems in my hardware.
Nobin Mathew