On Tue, Apr 09, 2024 at 10:48:13AM +0800, Baojun Xu wrote:
Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop will work as a single speaker on SPI bus. The code support realtek as
Realtek
the primary codec.
...
{"INT33FE", }, {"INT3515", }, /* Non-conforming _HID for Cirrus Logic already released */
{"TXNW2781", },
This seems wrong. The ID here is correct from ACPI specification perspective. Can you elaborate why you think it's "non-conforming _HID"?
{"CLSA0100", }, {"CLSA0101", },
...
/* Non-conforming _HID for Cirrus Logic already released */ { "CLSA0100", (unsigned long)&cs35l41_hda }, { "CLSA0101", (unsigned long)&cs35l41_hda },
- { "TXNW2781", (unsigned long)&tas2781_hda },
Ditto.
{ }
...
@@ -39,6 +39,7 @@ snd-hda-scodec-cs35l56-spi-objs := cs35l56_hda_spi.o snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o snd-hda-scodec-component-objs := hda_component.o snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o +snd-hda-scodec-tas2781-spi-objs := tas2781_hda_spi.o tas2781_spi_fwlib.o
Actually these 'objs' has to be 'y', can you fix it in the prerequisite patch?
Also wondering why fwlib is only a requirement for SPI. How does I²C work?