On 02/28/2014 08:08 AM, Li.Xiubo@freescale.com wrote:
Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.
On Fri, Feb 28, 2014 at 04:00:38AM +0000, Li.Xiubo@freescale.com wrote:
> I'll send another patches to applied to use this for another CODEC
drivers.
> And there almost 80 files, Should I send them in one patch or split them into > individual patch for each CODEC driver ?
I'd suggest doing one patch that covers the boring drivers where the first thing they do is call set_cache_io() but split out the others into one patch per driver since the need more examination.
Got it.
Btw. be careful, just removing the set_cache_io() call will not work for
all
drivers. There are some MFD child devices which use regmap from the parent device. So dev_get_regmap() will return NULL for those.
@Lars,
Do you mean the CODEC drivers like wm5110 and wm8997 ?
Yes.
I only found these two CODEC drivers using MFD who would get its parent's regmap.
Has I missed some ?
A quick grep reveals: mc13783.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL); si476x.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL); wm5102.c: codec->control_data = priv->core.arizona->regmap; wm5110.c: codec->control_data = priv->core.arizona->regmap; wm8997.c: codec->control_data = priv->core.arizona->regmap;
But there might be more.