On Thu, 27 Jun 2024 at 17:16, Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wrote:
On 27/06/2024 15:38, Dmitry Baryshkov wrote:
On Thu, Jun 27, 2024 at 12:55:20PM GMT, Srinivas Kandagatla wrote:
Add support to parse static master port map information from device tree. This is required for correct port mapping between soundwire device and master ports.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
sound/soc/codecs/wsa884x.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c index a9767ef0e39d..72ff71bfb827 100644 --- a/sound/soc/codecs/wsa884x.c +++ b/sound/soc/codecs/wsa884x.c @@ -1887,6 +1887,14 @@ static int wsa884x_probe(struct sdw_slave *pdev, wsa884x->sconfig.direction = SDW_DATA_DIR_RX; wsa884x->sconfig.type = SDW_STREAM_PDM;
- /**
* Port map index starts with 0, however the data port for this codec* are from index 1*/- if (of_property_read_u32_array(dev->of_node, "qcom,port-mapping", &pdev->m_port_map[1],
WSA884X_MAX_SWR_PORTS))dev_info(dev, "Static Port mapping not specified\n");Same comment. Either dev_warn (if it's something to warn about) or dev_info.
Or, as your commit message mentions that it is required, it should be an error if the port mapping is not specified.
That would be an ABI break.
Ok. So make it required just for new platforms. My point is that dev_info here is pretty pointless.