Hi, @Lars-Peter: thanks for the code review @Mark: You're right. The original source code (that I found on the web) was for kernel 2.6.35, and then I adapted it to work with kernel 3.2 series. Can you suggest me a "state of the art" codec driver where can I have a look at best practice? In the end the codec should work with alsa infrastructure available in kernel 3.2 so I can test it's correctness directly on my hw.
Thanks in advance, Paolo
On Mon, Oct 29, 2012 at 5:04 PM, Mark Brown < broonie@opensource.wolfsonmicro.com> wrote:
On Mon, Oct 29, 2012 at 09:43:57AM +0100, Paolo Doz wrote:
This codec driver adds support for Asahi Kasei AK5702.
Signed-off-by: Paolo Doz paolo.doz@gmail.com
Lars-Peter already went through most of this so I'll not follow up in detail. One overall comment which Lars-Peter didn't make but which it's worth bearing in mind was that your driver looks like it was written several years ago, it'd probably help a lot if you were to look at more modern drivers and make sure what you're doing resembles them stylistically.