Mike Frysinger wrote:
On Wed, Jun 3, 2009 at 10:53, Mark Brown wrote:
On Wed, Jun 03, 2009 at 08:37:54AM -0400, Mike Frysinger wrote:
On Wed, Jun 3, 2009 at 06:52, Mark Brown wrote:
However, given that this fix has missed two kernel releases due to the very slow rate of responses to review comments I've applied it so users get the benefit of the bug fix.
not sure what you're referring to
This looks like a respin of a fix which was originally submitted back in 2.6.29 era or so. IIRC there's been two or three versions, each of which needed fixes.
it could be. i was going by the changes that werent in 2.6.30. i thought i looked for previous submissions, but i must have missed previous attempts. i'm not familiar with alsa stuff, so i'm not always sure when i need to bang on Cliff to get things fixed up (changes split / better comments / etc...).
Anyways, this commit has been trying to fix something already fixed since the first submission and if you look at its effect on the current tree you will see duplicate code.