xOn Mon, Jul 8, 2024 at 1:08 PM Krzysztof Kozlowski krzk@kernel.org wrote:
On 07/07/2024 08:26, Animesh Agarwal wrote:
- va-supply:
- description: Voltage regulator phandle for the VA supply.
Your description is redundant: you did not say anything more than it is already said in the property name. This could be in such case just: ": true"
Please keep this feedback for any future work (I feel I already said it once...).
I'll add proper descriptions for each of these instead, thanks for the heads-up.
- vd-supply:
- description: Voltage regulator phandle for the VD supply.
- vlc-supply:
- description: Voltage regulator phandle for the VLC supply.
+required:
- compatible
- reg
+additionalProperties: false
This won't validate DTS... test the DTS. You miss dai-common.
Weirdly, this wasn't giving any errors upon running the dtbs_check, however I should fix this.
+examples:
- |
- i2c {
#address-cells = <1>;#size-cells = <0>;codec: cs4270@48 {Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre... e.g. audio-codec or codec
And drop unused label "codec:"
I can see some other cirrus bindings with this mistake, maybe because they were written/converted several years ago. I shall fix it here.
Best regards, Krzysztof