At Tue, 4 Jun 2013 10:49:22 -0400 (EDT), Alan Stern wrote:
On Tue, 4 Jun 2013, Takashi Iwai wrote:
At Mon, 3 Jun 2013 16:18:49 -0400 (EDT), Alan Stern wrote:
According to Takashi Iwai, CONFIG_SND_VERBOSE_PRINTK is "useless". All it does is add filenames and line numbers to certain log messages.
No, I did't mean it. The file name and line number are useful. What's useless is to let user select CONFIG_SND_VERBOSE_PRINTK. If the extra information can be annoying, the driver should use the plain printk() or whatever from the beginning. If the driver code chooses snd_printk(), it implies that it wants extra information.
Although most of the calls to snd_printk() are for errors and warnings, some of them are just informational. You don't mind having those messages suddenly including the filename and line number? (At least, until someone gets around to changing them to printk() or something else...)
I wouldn't mind but some might do :)
So we should clean up the excessive usage of snd_printk() and convert them to the standard printk & co at first.
Takashi