On 06/05/2014 04:12 PM, Takashi Iwai wrote:
At Thu, 05 Jun 2014 15:59:03 +0200, Daniel Mack wrote:
On 06/05/2014 03:53 PM, Takashi Iwai wrote:
At Thu, 5 Jun 2014 14:12:25 +0200, Daniel Mack wrote:
sound/sounc_core.c has a larger number of style issues. Fix them to make the code more readable. No functional change.
Signed-off-by: Daniel Mack zonque@gmail.com
Thanks for the patches, but are you going to fix anything in these codes along with them? Such coding style fixes just stir git history, which make often annoying for backporting or reviewing. So, basically I'd take such cleanup patches only if the real fixes will come together.
Yeah, I know that code is legacy. I was just skimming over the sources to trace a bug report on alsa-user, and stumbled over so many style issues that made reading the code harder than necessary that I couldn't resist fixing them :)
Ah, you're looking at usb disconnection issue? I just saw the thread now...
Jup. I was hoping that I could reproduce it here, but failed. The I had a quick look at the code, but I didn't find anything yet ...
Daniel