On Thu, Apr 07, 2011 at 09:31:10AM +0900, Sangbeom Kim wrote:
+config SND_SOC_SAMSUNG_SMDK_WM8580_PCM
- tristate
What is the purpose of this variable? Just the config for the machine should be enough.
@@ -1,12 +1,12 @@ -# S3c24XX Platform Support +# SAMSUNG Platform Support snd-soc-s3c24xx-objs := dma.o snd-soc-s3c24xx-i2s-objs := s3c24xx-i2s.o snd-soc-s3c2412-i2s-objs := s3c2412-i2s.o snd-soc-ac97-objs := ac97.o snd-soc-s3c-i2s-v2-objs := s3c-i2s-v2.o snd-soc-samsung-spdif-objs := spdif.o -snd-soc-pcm-objs := pcm.o -snd-soc-i2s-objs := i2s.o +snd-soc-samsung-pcm-objs := pcm.o +snd-soc-samsung-i2s-objs := i2s.o
These changes all look reasonable but they're unrelated to adding the machine driver and should be split out.
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 38aac7d..9c7e8b4 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai, ctl = readl(regs + S3C_PCM_CTL);
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
- case SND_SOC_DAIFMT_NB_NF:
/* Nothing to do, NB_NF by default */
- case SND_SOC_DAIFMT_IB_NF:
/* Nothing to do, IB_NF by default */
Similarly here, this is a bug fix so should be merged for 2.6.39.
- smdk_snd_device = platform_device_alloc("soc-audio", -1);
- if (!smdk_snd_device)
return -ENOMEM;
Please use snd_soc_register_card() for new machines rather than the soc-audio device. Otherwise the actual driver itself looks good.