Hi Ranjani
Thank you for review
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Card related function should be implemented at soc-card now. This patch adds it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
(snip)
+int snd_soc_card_set_bias_level(struct snd_soc_card *card,
struct snd_soc_dapm_context *dapm,enum snd_soc_bias_level level)+{
- int ret = 0;
- if (card->set_bias_level)
ret = card->set_bias_level(card, dapm, level);- return soc_card_ret(card, ret);
+} diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index a4de3e4bc2ef..add39d24a583 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -725,8 +725,8 @@ static int snd_soc_dapm_set_bias_level(struct snd_soc_dapm_context *dapm,
trace_snd_soc_bias_level_start(card, level);
- if (card && card->set_bias_level)
ret = card->set_bias_level(card, dapm, level);
- if (card)
Morimoto-san,
Why not move this check inside snd_soc_card_set_bias_level() and remove the first parameter from the function?
Oh, yes, indeed. We don't need "if (card)" check here.
But what does this "remove the first parameter from the function" mean ? Do you mean "remove card" ? Anyway, I will fixup [16/19] and [17/19] patches in v2
Thank you for your help !!
Best regards --- Kuninori Morimoto