Re: [PATCH 2/4] ASoC: rt5670: Remove 'HP Playback Switch' control

Dne 15. 02. 21 v 15:21 Hans de Goede napsal(a):

The RT5670_L_MUTE_SFT and RT5670_R_MUTE_SFT bits (bits 15 and 7) of the RT5670_HP_VOL register are set / unset by the headphones deplop code run by rt5670_hp_event() on SND_SOC_DAPM_POST_PMU / SND_SOC_DAPM_PRE_PMD.

So we should not also export a control to userspace which toggles these same bits.

I think that it may be worth to preserve the full-mute functionality. According the datasheet, the register 0x02 has volume range -46.5dB..12dB. Even the lowest volume may produce an audible output.

I would cache the mute switch value in rt5670_priv and update the POST_PMU/PRE_PMD code to use this settings.

Jaroslav