On Thu, Nov 17, 2016 at 12:16:06AM +0000, Kuninori Morimoto wrote:
Hi Charles
Thank you for your feedback
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Let's use module_i2c/spi_driver()
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Yeah I think from here on in the series these have the I2C/SPI issues Lars mentions.
I can create xx-i2c.c xx-spi.c as Lars mentioned. Do you think it is nice ? or do nothing for these drivers is nice ? If it is "nice to have", I can try it, please let me know.
I will fixup I2C side patches only, and post these as v2 patch. I will post I2C/SPI patches if these were "nice to have"
Creating the seperate I2C/SPI files would indeed be the best way to go, however, personally I would be inclined to leave them alone. They are mostly legacy parts, I won't have hardware to test almost all of them and there is no pressing need to update them at this time.
Thanks, Charles