28 Mar
2014
28 Mar
'14
9:25 a.m.
Hi Lars,
On 03/28/2014 10:00 AM, Lars-Peter Clausen wrote:
- if (ret < 0)
return ret;
+#endif
- /* GPIOs */
- if (gpio_is_valid(sta350->gpio_nreset)) {
ret = devm_gpio_request_one(&i2c->dev, sta350->gpio_nreset,
GPIOF_OUT_INIT_HIGH,
"ST350 Reset");
New code should use the GPIO descriptor API. See http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/...
Interesting new interface, missed that. Thanks for the pointer!
I changed all your remarks locally, but I'd like to give it a quick test. Will send v3 once I have confidence :)
Daniel