On Sat, Aug 14, 2010 at 1:09 PM, Jassi Brar jassisinghbrar@gmail.com wrote:
On Sat, Aug 14, 2010 at 4:33 AM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
This batch of patches should get the sample ratio selection for the WM8580 based on the configured sysclk correct, and also fixes a few random other things.
The configuration of the ADC clocking (which is slaved to the DAC clocking) is still not ideal - userspace has to configure playback at the sample rate to be used prior to starting a record - but this needs some more thought at the framework level since this is essentially the same problem we have when multiple DAIs run over one physical interface using TDM. Ideally we'd solve the more general problem.
Mark Brown (7): ASoC: Add a bit of resource unwinding in the S3C IISv4 driver ASoC: Convert WM8580 hw_params to use snd_soc_update_bits() ASoC: Remove unused rate selection bitmasks from WM8580 ASoC: Automatically calculate clock ratio for WM8580 ASoC: Implement BCLK rate selection for WM8580 ASoC: Fix inverted WM8580 capture mute control ASoC: Automatically manage WM8580 DAC OSR
Much needed changes. Thanks a lot. Happily, I am too occupied with other matters as well these days. I hope Claude(Seungwhan Youn) tests and give status on the patches.
Hi,
First of all, I'm really happy to test this patch-set. Thanks Mark. :-)
Anyway, I tested this patch-set about WM8580 updates with SMDK6410 board. Unfortunately, I faced with some problem in capture.
Briefly report of test is :- o Playback test with various frequency ; all works fine. 8000 Hz sampling freq. 11025 Hz sampling freq. 16000 Hz sampling freq. 22050 Hz sampling freq. 44100 Hz sampling freq. 48000 Hz sampling freq. 88200 Hz sampling freq. o Capture test ; it doesn't work, even after capture, playback also doesn't work.
I commented more details at corresponding patch.
Thanks, Claude