Re: [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings

Hello Krzysztof,

thank you for reviewing my patches.

On Thu, 8 Sep 2022 13:49:34 +0200 Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wrote:

On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:

...

From: Luca Ceresoli luca.ceresoli@bootlin.com

[...]

...

+properties:

• compatible:
• const: rockchip,rk3308-audio-graph-card

Is "graph" part of device name or you just put it there because of other schema?

Indeed this comes from the "audio-graph-card" compatible string.

The compatible should reflect the device name, not some other pieces in Linux or in bindings.

Would it be OK to rename it to rockchip,rk3308-audio-card (i.e. drop the "graph-" infix)?

Fixes for the other comments you made to this and the other patches are already queued for v2.

Best regards, Luca