-----Original Message----- From: Takashi Iwai tiwai@suse.de Sent: Friday, September 22, 2023 3:36 PM To: Stefan Binding sbinding@opensource.cirrus.com Cc: Mark Brown broonie@kernel.org; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com; alsa-devel@alsa- project.org; linux-kernel@vger.kernel.org; patches@opensource.cirrus.com Subject: Re: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares
using
unsupported commands
On Fri, 22 Sep 2023 16:28:16 +0200, Stefan Binding wrote:
Some systems use older firmware which does not support newer
commands
which are used to enable external boost. For those systems, we can workaround this by writing the registers directly.
We can use the firmware version, stored inside cs_dsp, to
determine
whether or not the command is supported. To achieve this, it requires a cleanup in the api, to pass the
cs_dsp
struct into the function.
We can also remove the redundant boolean firmware_running from the
HDA
driver, and use the equivalent state inside cs_dsp.
So those are fixes needed for 6.6 kernel? Or they are something
new?
These are to fix the issue that was reported on the Lenovo Legion 7 16ACHg6, which was introduced after the fixes to CS35L41 HDA System Suspend.
Thanks, Stefan
This chain is based on Mark's branch, since the api change was
made to
the function in sound/soc/codecs/cs35l41-lib.c.
I'd need a PR from Mark before applying those, then.
thanks,
Takashi