On 27/10/2023 19:32, syed saba kareem wrote:
On 10/27/23 21:53, Mark Brown wrote:
On Fri, Oct 27, 2023 at 10:54:47AM -0500, Mario Limonciello wrote:
What would actually go into MODULE_DEVICE_TABLE? The platform devices created are contingent upon what was found during the top level ACP driver probe. You don't want all the "child" platform drivers to load unless they're needed.
You want
MODULE_DEVICE_TABLE(platform, board_ids);
which is effectively the same as all the MODULE_ALIAS items you have there (which can be removed).
@krzk:as Mark Brown explained we can use platform device id table
instead of MODULE_ALIAS. As effectively there is no difference between
using platform device id table and MODULE_ALIAS.
There is a difference. MODULE_DEVICE_TABLE solves the problem and you do not need to spread aliases all over. This code is not equivalent. What's more, DEVICE_TABLE could be used for other purposes like dependency detection or ordering or whatever. ALIAS not.
If you are still expecting us to use platform id table instead of MODULE_ALIAS
Yes, I asked this first time.
we will provide the changes as an incremental patch.
Fix existing driver before adding new aliases. Then don't add ALIAS, how I asked already two times before.
Best regards, Krzysztof