On 2019-08-08 15:14, Takashi Iwai wrote:
On Thu, 08 Aug 2019 15:02:17 +0200, Mark Brown wrote:
On Thu, Aug 08, 2019 at 03:00:06PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
No, they absolutely should tell the user why they are deferring so the user has some information to go on when they're trying to figure out why their device isn't instantiating.
But it's no real error that *must* be printed on the console, either. Maybe downgrading the printk level?
Yes, downgrading can be OK though it does bloat the code.
I guess we can use dev_printk() with the conditional level choice.
How about use dev_info always? We get a dev_err message from soc_init_dai_link in error cases...
ret = soc_init_dai_link(card, dai_link); if (ret && ret != -EPROBE_DEFER) { dev_info(card->dev, "ASoC: failed to init link %s: %d\n", dai_link->name, ret); } if (ret) { soc_cleanup_platform(card); mutex_unlock(&client_mutex); return ret; }
-- Stefan