Re: [PATCH v1 4/4] ALSA: hda/cirrus: Make CS8409 driver more generic by using fixups.

15 Mar 2021


      On Sat, 13 Mar 2021 12:34:10 +0100,
Vitaly Rodionov wrote:
...
@@ -1357,6 +1362,22 @@ static const struct hda_verb cs8409_cs42l42_init_verbs[] = {
   { 0x47, AC_VERB_SET_PROC_COEF,  0x0080 },     /* I2C mode */
   { 0x47, AC_VERB_SET_COEF_INDEX, 0x005b },     /* Set I2C bus speed */
   { 0x47, AC_VERB_SET_PROC_COEF,  0x0200 },     /* 100kHz I2C_STO = 2 */

{ 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-1-TX */
{ 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 },
{ 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x21 },
{ 0x24, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 },
{ 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x50 }, /* Widget node ASP-1-RX0 */
{ 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x20 },
{ 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xa1 },
{ 0x34, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x04 },
{ 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0xF0 }, /* Widget node ASP-2-TX */
{ 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 },
{ 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0x10 },
{ 0x2C, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 },
{ 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_0, 0x90 }, /* Widget node DMIC-1 */
{ 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_1, 0x00 },
{ 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_2, 0xA0 },
{ 0x44, AC_VERB_SET_CONFIG_DEFAULT_BYTES_3, 0x90 },

Those widgets are all pin widgets, right?  If so, setting via the
pincfg table would be more suitable, as it's cached and exposed via
sysfs for debugging.
thanks,
Takashi

    

Takashi Iwai