Re: [alsa-devel] [PATCH 19/19] ALSA: SoC Audio support for OMAP4 boards with Yamaha YMU831 codec

On Wed, Jan 16, 2013 at 05:46:01PM +0900, Yoichi Yuasa wrote:

• base = ioremap(0x4a004108, 16);
• if (base) {

• if (params_rate(params) < 16000) {
  

• 	internal_freq /= 4;
  

• 	iowrite32(ioread32(base) | 0x02, base);
  

• } else
  

• 	iowrite32(ioread32(base) & ~0x02, base);
  

• iounmap(base);
  

• }

You can't be seriously trying to include this code in mainline... you're poking at random magic numbers in the CPU address space.

+static int omap_ymu831_init(struct snd_soc_pcm_runtime *rtd) +{

• rtd->pmdown_time = 500;
• return 0;

+}

Why?