Le 06/01/2023 à 17:37, Herve Codina a écrit :
The QMC (QUICC Multichannel Controller) is available on some PowerQUICC SoC such as the MPC885 or MPC866.
Same, that's QMC for CPM for the time being, should that be made clear in the subject ?
QE also has QMC and this driver might be used for QE QMC as well with some enhancement, maybe that could be explained here ?
I see you are using in_be16(), out_be16() etc .... That's specific to powerpc arch, maybe it is better to use ioread16be, iowrite16be() etc .... See commit 3f39f38ea91d ("soc: fsl: qe: replace qe_io{read,write}* wrappers by generic io{read,write}*") and commit 6ac9b61786cc ("soc: fsl: qe: introduce qe_io{read,write}* wrappers") for information.
It emulates up to 64 channels within one serial controller using the same TDM physical interface routed from the TSA.
Signed-off-by: Herve Codina herve.codina@bootlin.com
In some places, you comments use the network style, not the generic style.
Christophe