15 Sep
2011
15 Sep
'11
12:26 p.m.
On Wed, Sep 14, 2011 at 04:51:24PM -0500, Timur Tabi wrote:
- i = snd_pcm_format_width(params_format(params));
- switch (i) {
Just a minor nitpick. I would not have used the intermediate 'i' here and would have just embedded the snd_pcm call within the switch(). I guess it may not fit the line width though.
'i' is used twice:
switch (i) {
and
dev_err(codec->dev, "Unsupported sample size: %i\n", i);
There's no meaningful cost in calling the function twice and it'd be much more legible to do so.