Re: [alsa-devel] [PATCH 1/3] [PATCH] ASoC: acpi: fix machine driver selection based on quirk

On Wed, 2018-01-03 at 11:02 -0600, Pierre-Louis Bossart wrote:

The ACPI/machine-driver code refactoring introduced in 4.13 introduced a regression for cases where we need a DMI-based quirk to select the machine driver (the BIOS reports an invalid HID). The fix is just to make sure the results of the quirk are actually used.

for (mach = machines; mach->id[0]; mach++) { if (snd_soc_acpi_check_hid(mach->id) == true) { if (mach->machine_quirk(mach) != NULL)

Just a nit: perhaps use more natural style, i.e. drop " != NULL" part off?

• 		mach = mach->machine_quirk(mach);
  

• 	return mach;
  

  } } return NULL;