On Fri, Sep 04, 2020 at 09:01:03AM +0900, Kuninori Morimoto wrote:
Should dai's ::shutdown() be introducing some kind of state-check from now on? - similarly to how developers deal with some of the core pcm operations e.g.: ::prepare() (as it may get invoked multiple times in a row so check is there to prevent redundancy). Or, perhaps behavior change should be reverted with ::shutdown() routine again being called only after successful ::startup()?
I'm sorry but I couldn't 100% understand your opinion. But I understand that it is related to rollback order. Now I'm posting patch for it. It is not yet 100% but 1st step. Does it help for you ?
https://lore.kernel.org/r/87wo1kvozz.wl-kuninori.morimoto.gx@renesas.com
It's not just the ordering, it's more the fact that we will clean up things which failed to initialize.