Re: [alsa-devel] [PATCH] ALSA: echoaudio: cleanup of unnecessary messages

On Tue, 2014-11-04 at 23:47 +0530, Sudip Mukherjee wrote:

commit "b5b4a41b392960010fccf1f9ccf8334d612bd450" was dereferencing chip after it has been freed. This patch fixes that and at the same time removes some debugging messages, which are unnecessary, as they are just printing information about entry and exit from a function. This information we can easily get from ftrace.

Mostly true.

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c

[]

@@ -763,10 +755,8 @@ static int pcm_trigger(struct snd_pcm_substream *substream, int cmd) spin_lock(&chip->lock); switch (cmd) { case SNDRV_PCM_TRIGGER_RESUME:

• dev_dbg(chip->card->dev, "pcm_trigger resume\n");
  

  case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

• dev_dbg(chip->card->dev, "pcm_trigger start\n");
  

  for (i = 0; i < DSP_MAXPIPES; i++) { if (channelmask & (1 << i)) { pipe = chip->substream[i]->runtime->private_data;

These may not be useful but this switch state information can't be got from ftrace.