On Tue, Jun 02, 2015 at 12:07:32PM +0100, Mark Brown wrote:
On Tue, Jun 02, 2015 at 12:53:00PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
Ugh, and the functions are macros so can't be used directly. I'd still expect to see these ops be defined in some central place and reused.
Maybe we can lift up some time later, but it's nothing more than an optimization, so in a low priority for now.
It's not like it's hard to do and given that my concerns around this series mostly center around code reuse and abstraction I'd rather not have big warning signs type issues sitting there obscuring other things.
well these are read/write to registers, for SKL hidden behind writel, but in code do help in providing functionality of reading/writing bytes/words
This is fairly *common* in drivers to use wrappers for hw accesses and yes for overall HDA we can perhaps optimize these as Takashi pointed out but hardly a worrying aspect/sign
Thanks