Re: [PATCH v4 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings

On 11/6/2021 7:00 AM, Rob Herring wrote: Thanks for Your time Rob!!!

On Tue, Nov 2, 2021 at 5:57 AM Srinivasa Rao Mandadapu srivasam@codeaurora.org wrote:

...

On 10/30/2021 12:37 AM, Stephen Boyd wrote: Thanks for Your time Stephen!!!

...

Quoting Srinivasa Rao Mandadapu (2021-10-29 08:04:35)

...

diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml new file mode 100644 index 0000000..3a781c8 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -0,0 +1,170 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/google,sc7280-herobrine.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Google SC7280-Herobrine ASoC sound card driver

+maintainers:

• • Srinivasa Rao Mandadapu srivasam@codeaurora.org
• • Judy Hsiao judyhsiao@chromium.org

+description:

• This binding describes the SC7280 sound card which uses LPASS for audio.

+properties:

• compatible:
• enum:

•  - google,sc7280-herobrine
  

• audio-routing:
• $ref: /schemas/types.yaml#/definitions/non-unique-string-array
• description:

•  A list of the connections between audio components. Each entry is a
  

•  pair of strings, the first being the connection's sink, the second
  

•  being the connection's source.
  

• model:
• $ref: /schemas/types.yaml#/definitions/string
• description: User specified audio sound card name
• "#address-cells":
• const: 1
• "#size-cells":
• const: 0

+patternProperties:

• "^dai-link@[0-9a-f]$":
• description:

•  Each subnode represents a dai link. Subnodes of each dai links would be
  

•  cpu/codec dais.
  

• type: object
• properties:

•  link-name:
  

•    description: Indicates dai-link name and PCM stream name.
  

•    $ref: /schemas/types.yaml#/definitions/string
  

•    maxItems: 1
  

•  reg:
  

•    maxItems: 1
  

•    description: dai link address.
  

•  cpu:
  

•    description: Holds subnode which indicates cpu dai.
  

•    type: object
  

•    properties:
  

•      sound-dai: true
  

Is sound-dai required? And additionalProperties is false? I think we need that yet again.

Okay. Will mark additionalPropertiesas true.

'additiionalProperties: true' is almost never right. It's generally only correct for schemas that are incomplete collections of properties.

Rob

As per Stephen Suggestion. thought it's a solution.

The sound-dai required here, and same is fallowed in SC7180 machine driver bindings.

Could You please suggest better approach on this?